netdev - Re: [PATCH net-next v8 1/6] net: dsa: mv88e6xxx: Add RMU enable for select switches.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220911121905.hhjauibp237r6dgk@skbuf>
Date:   Sun, 11 Sep 2022 15:19:05 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Mattias Forsblad <mattias.forsblad@...il.com>,
        netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v8 1/6] net: dsa: mv88e6xxx: Add RMU enable for
 select switches.

On Fri, Sep 09, 2022 at 10:34:35AM -0700, Florian Fainelli wrote:
> > +	int (*rmu_enable)(struct mv88e6xxx_chip *chip, int port);
> 
> Change the argument name to upstream_port to match the implementation for
> each chip that you are adding?

Or the implementations to "port", for that matter. But yes, please keep consistency.