netdev - Re: [PATCH net] netdevsim: Fix hwstats debugfs file permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87pmg1dl5z.fsf@nvidia.com>
Date:   Mon, 12 Sep 2022 10:57:06 +0200
From:   Petr Machata <petrm@...dia.com>
To:     Ido Schimmel <idosch@...dia.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>, <kuba@...nel.org>,
        <pabeni@...hat.com>, <edumazet@...gle.com>, <petrm@...dia.com>,
        <jie2x.zhou@...el.com>, <mlxsw@...dia.com>
Subject: Re: [PATCH net] netdevsim: Fix hwstats debugfs file permissions


Ido Schimmel <idosch@...dia.com> writes:

> The hwstats debugfs files are only writeable, but they are created with
> read and write permissions, causing certain selftests to fail [1].
>
> Fix by creating the files with write permission only.
>
> [1]
>  # ./test_offload.py
>  Test destruction of generic XDP...
>  Traceback (most recent call last):
>    File "/home/idosch/code/linux/tools/testing/selftests/bpf/./test_offload.py", line 810, in <module>
>      simdev = NetdevSimDev()
>  [...]
>  Exception: Command failed: cat /sys/kernel/debug/netdevsim/netdevsim0//ports/0/dev/hwstats/l3/disable_ifindex
>
>  cat: /sys/kernel/debug/netdevsim/netdevsim0//ports/0/dev/hwstats/l3/disable_ifindex: Invalid argument
>
> Fixes: 1a6d7ae7d63c ("netdevsim: Introduce support for L3 offload xstats")
> Reported-by: Jie2x Zhou <jie2x.zhou@...el.com>
> Tested-by: Jie2x Zhou <jie2x.zhou@...el.com>
> Signed-off-by: Ido Schimmel <idosch@...dia.com>

Reviewed-by: Petr Machata <petrm@...dia.com>