netdev - Re: [RFC PATCH net-next 3/3] net: dsa: never skip VLAN configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220913150936.rue4e2cuv2fkdf7b@skbuf>
Date:   Tue, 13 Sep 2022 15:09:36 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     "Arun.Ramadoss@...rochip.com" <Arun.Ramadoss@...rochip.com>
CC:     Claudiu Manoil <claudiu.manoil@....com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "idosch@...dia.com" <idosch@...dia.com>,
        "linux@...pel-privat.de" <linux@...pel-privat.de>,
        "petrm@...dia.com" <petrm@...dia.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "hauke@...ke-m.de" <hauke@...ke-m.de>,
        "martin.blumenstingl@...glemail.com" 
        <martin.blumenstingl@...glemail.com>,
        Xiaoliang Yang <xiaoliang.yang_1@....com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woojung.Huh@...rochip.com" <Woojung.Huh@...rochip.com>,
        "davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [RFC PATCH net-next 3/3] net: dsa: never skip VLAN configuration

On Tue, Sep 13, 2022 at 10:57:44AM +0000, Arun.Ramadoss@...rochip.com wrote:
> In addition to above config, I had set CONFIG_NAMESPACES=y, then the
> above error message disappered.
> But the ping is not successful. 
> 
> If I change the setup like
> Linux laptop 1 --> DUT1 (Lan2) --> DUT1 (Lan3) --> Linux laptop 2
> then ping is successful.
> 
> If I use the standard kselftest setup 
> lan1 --> lan2 --> lan3 --> lan4, ping is not success.
> 
> I went through the comments given in this thread to bring up ping for
> openwrt, is that applicable to kselftest also. 
> 
> ip netns add ns0
> ip link set lan2 netns ns0
> ip -n ns0 link set lan2 up
> ip -n ns0 addr add 192.168.2.2/24 dev lan2 
> ip netns exec ns0 tcpdump -i lan2 -e -n
> ping 192.168.2.2

You meant to put lan4 in a namespace and ping it and not lan2, since
lan2 will be a bridge port, right?

> I am struck with the ping test bringup. It would be helpful, if you can
> give some suggestion to bring it up.

Well, do you have unique MAC addresses for lan1, lan2, lan3, lan4? The
kselftests will ensure you do, via the STABLE_MAC_ADDRS variable, but
otherwise you may not.

Then, can you tell us what packets you do see reaching lan4 in the ping
setup? If none, can you show us the output of ethtool -S lan2 | grep -v ': 0'
to figure out what is the drop reason (supposing the packets are dropped
at the ingress of lan2)? Or even tcpdump -i lan2, maybe the packets are
forwarded to the termination plane of the bridge, instead of being
autonomously forwarded to lan3.