lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220913155116.GA3801652-robh@kernel.org> Date: Tue, 13 Sep 2022 10:51:16 -0500 From: Rob Herring <robh@...nel.org> To: Vladimir Oltean <vladimir.oltean@....com> Cc: Sean Wang <sean.wang@...iatek.com>, Paolo Abeni <pabeni@...hat.com>, Kurt Kanzenbach <kurt@...utronix.de>, DENG Qingfang <dqfext@...il.com>, Arınç ÜNAL <arinc.unal@...nc9.com>, linux-kernel@...r.kernel.org, George McCollister <george.mccollister@...il.com>, linux-arm-kernel@...ts.infradead.org, linux-renesas-soc@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Florian Fainelli <f.fainelli@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Andrew Lunn <andrew@...n.ch>, Woojung Huh <woojung.huh@...rochip.com>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, UNGLinuxDriver@...rochip.com, Clément Léger <clement.leger@...tlin.com>, devicetree@...r.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, linux-mediatek@...ts.infradead.org, Matthias Brugger <matthias.bgg@...il.com>, Rob Herring <robh+dt@...nel.org>, Landen Chao <Landen.Chao@...iatek.com>, Vladimir Oltean <olteanv@...il.com>, John Crispin <john@...ozen.org>, Vivien Didelot <vivien.didelot@...il.com>, Marek Vasut <marex@...x.de>, Alvin Šipraga <alsi@...g-olufsen.dk>, netdev@...r.kernel.org Subject: Re: [PATCH net-next 1/3] dt-bindings: net: dsa: mt7530: replace label = "cpu" with proper checks On Mon, 12 Sep 2022 20:50:56 +0300, Vladimir Oltean wrote: > The fact that some DSA device trees use 'label = "cpu"' for the CPU port > is nothing but blind cargo cult copying. The 'label' property was never > part of the DSA DT bindings for anything except the user ports, where it > provided a hint as to what name the created netdevs should use. > > DSA does use the "cpu" port label to identify a CPU port in dsa_port_parse(), > but this is only for non-OF code paths (platform data). > > The proper way to identify a CPU port is to look at whether the > 'ethernet' phandle is present. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com> > --- > .../devicetree/bindings/net/dsa/mediatek,mt7530.yaml | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > Acked-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists