netdev - RE: [PATCH 2/5] dt-bindings: net: renesas: Document Renesas Ethernet Switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2022 05:56:27 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "geert+renesas@...der.be" <geert+renesas@...der.be>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH 2/5] dt-bindings: net: renesas: Document Renesas Ethernet
 Switch

Hi Andrew,

Thank you for your review!

> From: Andrew Lunn, Sent: Tuesday, September 13, 2022 7:32 AM
> 
> > +  '#address-cells':
> > +    description: Number of address cells for the MDIO bus.
> > +    const: 1
> 
> Please could you explain this a bit more.

I realized that the property is completely wrong.
This #address-cells here (out of "port") is not needed.
So, I'll drop it.
Instead of that, I'll add a description of "#address-cell"
in the port as " Port number of ETHA (TSNA)".

> > +
> > +  '#size-cells':
> > +    description: Number of size cells on the MDIO bus.
> > +    const: 0

Also I'll drop this.

> > +  ports:
> > +    type: object
> 
> I think ethernet-ports is the preferred name.

OK. I'll rename it.

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - reg-names
> > +  - interrupts
> > +  - interrupt-names
> > +  - clocks
> > +  - clock-names
> > +  - resets
> > +  - power-domains
> > +  - '#address-cells'
> > +  - '#size-cells'
> 
> So ports are not required? You can have a 0 port switch?

Thank you for pointed it out. I'll add "ethernet-ports" and
drop '#address-cells' and '#size-cells'.

Best regards,
Yoshihiro Shimoda

>    Andrew