netdev - Re: gmac1 issues with mtk_eth_soc & port 5 issues with MT7530 DSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Sep 2022 15:45:05 +0200
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>,
        netdev <netdev@...r.kernel.org>
CC:     Lorenzo Bianconi <lorenzo@...nel.org>,
        Sergio Paracuellos <sergio.paracuellos@...il.com>
Subject: Re: gmac1 issues with mtk_eth_soc & port 5 issues with MT7530 DSA driver

Am 13. September 2022 14:54:20 MESZ schrieb "Arınç ÜNAL" <arinc.unal@...nc9.com>:
>I'd like to post a few more issues I stumbled upon on mtk_eth_soc and MT7530 DSA drivers. All of this is tested on vanilla 6.0-rc5 on GB-PC2.
>
>## MT7621 Ethernet gmac1 won’t work when gmac1 is used as DSA master for MT7530 switch
>
>There’s recently been changes on the MT7530 DSA driver by Frank to support using port 5 as a CPU port.
>
>The MT7530 switch’s port 5 is wired to the MT7621 SoC’s gmac1.
>
>Master eth1 and slave interfaces initialise fine. Packets are sent out from eth1 fine but won't be received on eth1.
>
>This issue existed before Lorenzo’s changes on 6.0-rc1.
>
>I’m not sure if this is an issue with mtk_eth_soc or the MT7530 DSA driver.
>
>---
>
>## MT7530 sends malformed packets to/from CPU at port 5 when port 6 is not defined on devicetree
>
>In this case, I can see eth1 receiving traffic as the receive counter on ifconfig goes up with the ARP packets sent to the mt7621 CPU.
>
>I see the mt7621 CPU not responding to the ARP packets (no malformed packets or anything), which likely means ARP packets received on the mt7621 CPU side are also malformed.
>
>I think this confirms that the above issue is related to the MT7530 DSA driver as I can see eth1 receiving traffic in this case.
>
>Packet capture of the malformed packets are in the attachments.
>
>---
>
>## MT7621 Ethernet gmac1 won’t work when gmac0 is not defined on devicetree
>
>eth0 interface is initalised even though it’s not defined on the devicetree, eth1 interface is not created at all.
>
>This is likely not related to the MT7530 DSA driver.
>
>Arınç
There are some patches fixing ethernet and dsa driver for getting sfps to work.

https://git.openwrt.org/?p=openwrt/staging/dangole.git;a=commit;h=9469ba3568d7d9de31dc63de5269c848a1cc1dc7

And on dsa side imho only to support sfp

https://github.com/openwrt/openwrt/commit/bd6783f4fb8f6171927e9067c0005a6d69fc13fe

Hope the first patches help you with your issue

regards Frank