lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Sep 2022 12:38:11 +0000 From: Raed Salem <raeds@...dia.com> To: Yang Yingliang <yangyingliang@...wei.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org> CC: Saeed Mahameed <saeedm@...dia.com>, Lior Nahmanson <liorna@...dia.com>, "davem@...emloft.net" <davem@...emloft.net> Subject: RE: [PATCH -next 2/2] net/mlx5e: Switch to kmemdup() when allocate dev_addr >-----Original Message----- >From: Yang Yingliang <yangyingliang@...wei.com> >Sent: Tuesday, 13 September 2022 17:37 >To: netdev@...r.kernel.org; linux-rdma@...r.kernel.org >Cc: Saeed Mahameed <saeedm@...dia.com>; Lior Nahmanson ><liorna@...dia.com>; Raed Salem <raeds@...dia.com>; >davem@...emloft.net >Subject: [PATCH -next 2/2] net/mlx5e: Switch to kmemdup() when allocate >dev_addr > >External email: Use caution opening links or attachments > > >Use kmemdup() helper instead of open-coding to simplify the code when >allocate dev_addr. > >Signed-off-by: Yang Yingliang <yangyingliang@...wei.com> >--- > drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c >b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c >index 5fa3e22c8918..0f7c5b9a3541 100644 >--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c >+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c >@@ -934,14 +934,14 @@ static int mlx5e_macsec_add_secy(struct >macsec_context *ctx) > goto out; > } > >- macsec_device->dev_addr = kzalloc(dev->addr_len, GFP_KERNEL); >+ macsec_device->dev_addr = kmemdup(dev->dev_addr, dev->addr_len, >+ GFP_KERNEL); I think it could fit in one line (the kmemdup function call) > if (!macsec_device->dev_addr) { > kfree(macsec_device); > err = -ENOMEM; > goto out; > } > >- memcpy(macsec_device->dev_addr, dev->dev_addr, dev->addr_len); > macsec_device->netdev = dev; > > INIT_LIST_HEAD_RCU(&macsec_device->macsec_rx_sc_list_head); >-- >2.25.1 Thanks, good catch
Powered by blists - more mailing lists