lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Sep 2022 10:14:14 -0500 From: Rob Herring <robh@...nel.org> To: Arınç ÜNAL <arinc.unal@...nc9.com> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Matthias Brugger <matthias.bgg@...il.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>, DENG Qingfang <dqfext@...il.com>, Sergio Paracuellos <sergio.paracuellos@...il.com>, erkin.bozoglu@...ont.com, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org Subject: Re: [PATCH 04/10] dt-bindings: memory: mt7621: add syscon as compatible string On Wed, Sep 14, 2022 at 11:54:45AM +0300, Arınç ÜNAL wrote: > Add syscon as a constant string on the compatible property as it's required > for the SoC to work. Update the example accordingly. It's not required. It's required to automagically create a regmap. That can be done yourself as well. The downside to adding 'syscon' is it requires a DT update. Maybe that's fine for this platform? I don't know. > > Fixes: 5278e4a181ff ("dt-bindings: memory: add binding for Mediatek's MT7621 SDRAM memory controller") > Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com> > --- > .../bindings/memory-controllers/mediatek,mt7621-memc.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml > index 85e02854f083..6ccdaf99c778 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,mt7621-memc.yaml > @@ -11,7 +11,9 @@ maintainers: > > properties: > compatible: > - const: mediatek,mt7621-memc > + items: > + - const: mediatek,mt7621-memc > + - const: syscon > > reg: > maxItems: 1 > @@ -25,6 +27,6 @@ additionalProperties: false > examples: > - | > memory-controller@...0 { > - compatible = "mediatek,mt7621-memc"; > + compatible = "mediatek,mt7621-memc", "syscon"; > reg = <0x5000 0x1000>; > }; > -- > 2.34.1 > >
Powered by blists - more mailing lists