netdev - Re: [PATCH -next v2 1/2] net/mlx5e: add missing error code in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220914201028.5e7uhpmiolls2aw4@sx1>
Date:   Wed, 14 Sep 2022 21:10:28 +0100
From:   Saeed Mahameed <saeedm@...dia.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        liorna@...dia.com, raeds@...dia.com, davem@...emloft.net
Subject: Re: [PATCH -next v2 1/2] net/mlx5e: add missing error code in error
 path

On 14 Sep 22:00, Yang Yingliang wrote:
>Add missing error code when mlx5e_macsec_fs_add_rule() or
>mlx5e_macsec_fs_init() fails. mlx5e_macsec_fs_init() don't
>return ERR_PTR(), so replace IS_ERR_OR_NULL() check with
>NULL pointer check.
>
>Fixes: e467b283ffd5 ("net/mlx5e: Add MACsec TX steering rules")
>Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
>---
>v2:
>  Replace IS_ERR_OR_NULL() check with NULL pointer check.
>---

Acked-by: Saeed Mahameed <saeedm@...dia.com>

netdev maintainers please apply directly.

Thanks.