lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Sep 2022 23:03:35 +0000 From: Vladimir Oltean <vladimir.oltean@....com> To: Vinicius Costa Gomes <vinicius.gomes@...el.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Xiaoliang Yang <xiaoliang.yang_1@....com>, Rui Sousa <rui.sousa@....com>, Claudiu Manoil <claudiu.manoil@....com>, Alexandre Belloni <alexandre.belloni@...tlin.com>, "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Michael Walle <michael@...le.cc>, Maxim Kochetkov <fido_max@...ox.ru>, Colin Foster <colin.foster@...advantage.com>, Richie Pearn <richard.pearn@....com>, Kurt Kanzenbach <kurt@...utronix.de>, Vladimir Oltean <olteanv@...il.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, Gerhard Engleder <gerhard@...leder-embedded.com>, Grygorii Strashko <grygorii.strashko@...com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next 04/13] net/sched: taprio: allow user input of per-tc max SDU On Wed, Sep 14, 2022 at 04:00:07PM -0700, Vinicius Costa Gomes wrote: > Hm, I just noticed something. > > During parse the user only sets the max-sdu for the traffic classes she > is interested on. During dump you are showing all of them, the unset > ones will be shown as zero, that seems a bit confusing, which could mean > that you would have to add some checks anyway. > > For the offload side, you could just document that U32_MAX means unset. Yes, choosing '0' rather than other value, to mean 'default to port MTU' was intentional. It is also in line with what other places, like the YANG models, expect to see: https://github.com/YangModels/yang/blob/main/standard/ieee/draft/802.1/Qcw/ieee802-dot1q-sched.yang#L128
Powered by blists - more mailing lists