netdev - RE: [PATCH net-next 3/3] nfp: implement xfrm callbacks and expose ipsec offload feature to upper layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH2PR13MB370270E849C46D94BD9291FBFC469@CH2PR13MB3702.namprd13.prod.outlook.com>
Date:   Wed, 14 Sep 2022 03:10:41 +0000
From:   Yinjun Zhang <yinjun.zhang@...igine.com>
To:     Leon Romanovsky <leon@...nel.org>,
        Simon Horman <simon.horman@...igine.com>
CC:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        oss-drivers <oss-drivers@...igine.com>
Subject: RE: [PATCH net-next 3/3] nfp: implement xfrm callbacks and expose
 ipsec offload feature to upper layer

On Wed, 7 Sep 2022 21:06:30 +0300, Leon Romanovsky wrote:
> On Wed, Sep 07, 2022 at 11:47:58AM +0200, Simon Horman wrote:
> > From: Huanhuan Wang <huanhuan.wang@...igine.com>
> >
> > Xfrm callbacks are implemented to offload SA info into firmware
> > by mailbox. It supports 16K SA info in total.
> >
> > Expose ipsec offload feature to upper layer, this feature will
> > signal the availability of the offload.
> >
> > Based on initial work of Norm Bagley <norman.bagley@...ronome.com>.
> >
> > Signed-off-by: Huanhuan Wang <huanhuan.wang@...igine.com>
> > Reviewed-by: Louis Peens <louis.peens@...igine.com>
> > Signed-off-by: Simon Horman <simon.horman@...igine.com>
> > ---
> >  .../net/ethernet/netronome/nfp/crypto/ipsec.c | 552
> +++++++++++++++++-
> >  .../ethernet/netronome/nfp/nfp_net_common.c   |   6 +
> >  .../net/ethernet/netronome/nfp/nfp_net_ctrl.h |   4 +-
> >  3 files changed, 558 insertions(+), 4 deletions(-)
> 
> <...>
> 
> > +	if (x->props.flags & XFRM_STATE_ESN)
> > +		cfg->ctrl_word.ext_seq = 1;
> > +	else
> > +		cfg->ctrl_word.ext_seq = 0;
> 
> Don't you need to implement xdo_dev_state_advance_esn() too?
> 

Actually ESN is not well-supported yet. To clarify, we'll prepare a v2 to explicitly
return failure here. Thanks.

> Thanks