netdev - Re: [PATCH] net: clear msg_get_inq in __get_compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26a1465a-3ab6-9c30-8461-788f46cdb8a2@kernel.dk>
Date:   Wed, 14 Sep 2022 03:54:45 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: clear msg_get_inq in __get_compat_msghdr()

On 9/14/22 3:51 AM, Tetsuo Handa wrote:
> syzbot is still complaining uninit-value in tcp_recvmsg(), for
> commit 1228b34c8d0ecf6d ("net: clear msg_get_inq in __sys_recvfrom() and
> __copy_msghdr_from_user()") missed that __get_compat_msghdr() is called
> instead of copy_msghdr_from_user() when MSG_CMSG_COMPAT is specified.

Looks good to me:

Reviewed-by: Jens Axboe <axboe@...nel.dk>

-- 
Jens Axboe