netdev - Re: [PATCH v2] wcn36xx: Add RX frame SNR as a source of system entropy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cbfa8d05-48a5-4950-a852-ad018d70da8e@linaro.org>
Date:   Thu, 15 Sep 2022 01:14:08 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     loic.poulain@...aro.org, kvalo@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] wcn36xx: Add RX frame SNR as a source of system
 entropy

On 15/09/2022 00:57, Jason A. Donenfeld wrote:
> Won't this break on big endian? Just have an assignment handle it:
> 

Yes but these SoCs are all LE

>      u8 snr_sample = snr & 0xff;
>      add_device_randomness(&snr_sample, sizeof(snr_sample);
> 
> That & 0xff is redundant, but it doesn't hurt to be explicit.

Sure NP I'll v3 it.

---
bod