lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Sep 2022 14:29:00 +0530 From: Siddharth Vadapalli <s-vadapalli@...com> To: "Russell King (Oracle)" <linux@...linux.org.uk> CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>, <robh+dt@...nel.org>, <krzysztof.kozlowski@...aro.org>, <krzysztof.kozlowski+dt@...aro.org>, <vladimir.oltean@....com>, <grygorii.strashko@...com>, <vigneshr@...com>, <nsekhar@...com>, <netdev@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <kishon@...com>, <s-vadapalli@...com> Subject: Re: [PATCH 5/8] net: ethernet: ti: am65-cpsw: Add support for fixed-link configuration Hello Russell, On 14/09/22 21:11, Russell King (Oracle) wrote: > On Wed, Sep 14, 2022 at 03:20:50PM +0530, Siddharth Vadapalli wrote: >> diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c >> index 72b1df12f320..1739c389af20 100644 >> --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c >> +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c >> @@ -1494,10 +1494,50 @@ static void am65_cpsw_nuss_mac_config(struct phylink_config *config, unsigned in >> phylink_config); >> struct am65_cpsw_port *port = container_of(slave, struct am65_cpsw_port, slave); >> struct am65_cpsw_common *common = port->common; >> + struct fwnode_handle *fwnode; >> + bool fixed_link = false; >> >> if (common->pdata.extra_modes & BIT(state->interface)) >> writel(AM65_CPSW_SGMII_CONTROL_MR_AN_ENABLE, >> port->sgmii_base + AM65_CPSW_SGMII_CONTROL_REG); >> + >> + /* Detecting fixed-link */ >> + fwnode = of_node_to_fwnode(port->slave.phy_node); >> + if (fwnode) >> + fixed_link = !!fwnode_get_named_child_node(fwnode, "fixed-link"); >> + >> + if (fixed_link) { >> + /* In fixed-link mode, mac_link_up is not invoked. >> + * Therefore, the relevant mac_link_up operations >> + * have to be moved to mac_config. >> + */ > > This seems very wrong. Why is mac_link_up() not invoked? Have you > debugged this? It works for other people. > > Please debug rather than adding hacks to drivers when you find > things that don't seem to work. I will debug and find out. I had assumed that mac_link_up() is not invoked in fixed-link mode. Thank you for clarifying. Regards, Siddharth.
Powered by blists - more mailing lists