lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 15 Sep 2022 16:18:06 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Jilin Yuan <yuanjilin@...rlc.com>, habetsm.xilinx@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sfc: fix repeated words in comments

On 15/09/2022 08:54, Jilin Yuan wrote:
> Delete the redundant word 'in'.
> 
> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com>
> ---
>  drivers/net/ethernet/sfc/bitfield.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/sfc/bitfield.h b/drivers/net/ethernet/sfc/bitfield.h
> index 1f981dfe4bdc..0b502d1c3c9e 100644
> --- a/drivers/net/ethernet/sfc/bitfield.h
> +++ b/drivers/net/ethernet/sfc/bitfield.h
> @@ -117,7 +117,7 @@ typedef union efx_oword {
>   *
>   *   ( element ) << 4
>   *
> - * The result will contain the relevant bits filled in in the range
> + * The result will contain the relevant bits filled in the range
>   * [0,high-low), with garbage in bits [high-low+1,...).
>   */
>  #define EFX_EXTRACT_NATIVE(native_element, min, max, low, high)		\
> 

NACK, per [1].
Please stop using whatever tool is finding these, or find someone who can
 filter out the false positives.

-ed

[1]: https://lore.kernel.org/netdev/30f2488d-9af3-fe8d-6e6f-713a7d38800b@gmail.com/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ