netdev - Re: [RFC PATCH net-next v4 2/6] devlink: Extend devlink-rate api with queues and new parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f17166c7-312d-ac13-989e-b064cddcb49e@gmail.com>
Date:   Thu, 15 Sep 2022 16:31:31 +0100
From:   Edward Cree <ecree.xilinx@...il.com>
To:     Michal Wilczynski <michal.wilczynski@...el.com>,
        netdev@...r.kernel.org
Cc:     alexandr.lobakin@...el.com, dchumak@...dia.com, maximmi@...dia.com,
        jiri@...nulli.us, simon.horman@...igine.com,
        jacob.e.keller@...el.com, jesse.brandeburg@...el.com,
        przemyslaw.kitszel@...el.com
Subject: Re: [RFC PATCH net-next v4 2/6] devlink: Extend devlink-rate api with
 queues and new parameters

On 15/09/2022 14:42, Michal Wilczynski wrote:
> Currently devlink-rate only have two types of objects: nodes and leafs.
> There is a need to extend this interface to account for a third type of
> scheduling elements - queues. In our use case customer is sending
> different types of traffic on each queue, which requires an ability to
> assign rate parameters to individual queues.

Is there a use-case for this queue scheduling in the absence of a netdevice?
If not, then I don't see how this belongs in devlink; the configuration
 should instead be done in two parts: devlink-rate to schedule between
 different netdevices (e.g. VFs) and tc qdiscs (or some other netdev-level
 API) to schedule different queues within each single netdevice.
Please explain why this existing separation does not support your use-case.

Also I would like to see some documentation as part of this patch.  It looks
 like there's no kernel document for devlink-rate unlike most other devlink
 objects; perhaps you could add one?

-ed