netdev - Re: [PATCH net-next v12 5/6] net: dsa: mv88e6xxx: rmon: Use RMU for reading RMON data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22592ab8-ad68-0aca-c23c-72954b043ac0@gmail.com>
Date:   Thu, 15 Sep 2022 13:11:10 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Mattias Forsblad <mattias.forsblad@...il.com>,
        netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux@...linux.org.uk,
        ansuelsmth@...il.com
Subject: Re: [PATCH net-next v12 5/6] net: dsa: mv88e6xxx: rmon: Use RMU for
 reading RMON data

On 9/15/22 07:36, Mattias Forsblad wrote:
> Use the Remote Management Unit for efficiently accessing
> the RMON data.
> 
> Signed-off-by: Mattias Forsblad <mattias.forsblad@...il.com>

Seems a bit wasteful to add a rmu_reg field for each statistics member 
when there are only 6 STATS_TYPE_PORT that could be read over RMU.

Maybe what you could do is that the offset in the "reg" member could be 
split into a lower half that is used to encore the existing offset, and 
you use the upper half to encode the RMU-offset.
-- 
Florian