lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Sep 2022 16:23:10 -0700 From: Cong Wang <xiyou.wangcong@...il.com> To: Zhengchao Shao <shaozhengchao@...wei.com> Cc: netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kselftest@...r.kernel.org, jhs@...atatu.com, jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, shuah@...nel.org, ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org, yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org, weiyongjun1@...wei.com, yuehaibing@...wei.com Subject: Re: [PATCH net-next,v3 1/9] net/sched: cls_api: add helper for tc cls walker stats updating On Thu, Sep 15, 2022 at 02:30:30PM +0800, Zhengchao Shao wrote: > The walk implementation of most tc cls modules is basically the same. > That is, the values of count and skip are checked first. If count is > greater than or equal to skip, the registered fn function is executed. > Otherwise, increase the value of count. So we can reconstruct them. > > Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com> > Reviewed-by: Jamal Hadi Salim <jhs@...atatu.com> > --- > include/net/pkt_cls.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h > index d9d90e6925e1..d3cbbabf7592 100644 > --- a/include/net/pkt_cls.h > +++ b/include/net/pkt_cls.h > @@ -81,6 +81,19 @@ int tcf_classify(struct sk_buff *skb, > const struct tcf_proto *tp, struct tcf_result *res, > bool compat_mode); > > +static inline bool tc_cls_stats_update(struct tcf_proto *tp, This function name is confusing, I don't think it updates anything, probably we only dump stats when calling ->walk(). Please use a better name here, like tc_cls_stats_dump(). Thanks.
Powered by blists - more mailing lists