lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4fe4736d-ccc2-de00-8bb0-992382644fe6@quicinc.com> Date: Wed, 14 Sep 2022 22:13:57 -0700 From: Jeff Johnson <quic_jjohnson@...cinc.com> To: Jilin Yuan <yuanjilin@...rlc.com>, <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com> CC: <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] orinoco: fix repeated words in comments On 9/14/2022 8:54 PM, Jeff Johnson wrote: > On 9/14/2022 8:02 PM, Jilin Yuan wrote: >> Delete the redundant word 'this'. >> >> Signed-off-by: Jilin Yuan <yuanjilin@...rlc.com> >> --- >> drivers/net/wireless/intersil/orinoco/main.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/intersil/orinoco/main.h >> b/drivers/net/wireless/intersil/orinoco/main.h >> index 5a8fec26136e..852e1643dad2 100644 >> --- a/drivers/net/wireless/intersil/orinoco/main.h >> +++ b/drivers/net/wireless/intersil/orinoco/main.h >> @@ -12,7 +12,7 @@ >> /* Compile time configuration and compatibility stuff */ >> /********************************************************************/ >> -/* We do this this way to avoid ifdefs in the actual code */ >> +/* We do this way to avoid ifdefs in the actual code */ > > In this case the two instances of "this" are not a repetition, they are > different parts of speech. > > The existing sentence is correct English; the modified sentence is not. > > If the repeated word really bothers you then insert "in": We do this in > this way... > > >> #ifdef WIRELESS_SPY >> #define SPY_NUMBER(priv) (priv->spy_data.spy_number) >> #else > In addition the patch subject of all files in drivers/net/wireless should now begin with "wifi: "
Powered by blists - more mailing lists