lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <aca736cd-a2f9-2af9-df59-7f8be7c991b6@arinc9.com> Date: Thu, 15 Sep 2022 09:24:37 +0300 From: Arınç ÜNAL <arinc.unal@...nc9.com> To: Sergio Paracuellos <sergio.paracuellos@...il.com> Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, Matthias Brugger <matthias.bgg@...il.com>, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean <olteanv@...il.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Sean Wang <sean.wang@...iatek.com>, Landen Chao <Landen.Chao@...iatek.com>, DENG Qingfang <dqfext@...il.com>, erkin.bozoglu@...ont.com, netdev <netdev@...r.kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>, linux-arm-kernel@...ts.infradead.org, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>, linux-kernel <linux-kernel@...r.kernel.org>, "open list:MIPS" <linux-mips@...r.kernel.org> Subject: Re: [PATCH 04/10] dt-bindings: memory: mt7621: add syscon as compatible string On 15.09.2022 06:21, Sergio Paracuellos wrote: > On Wed, Sep 14, 2022 at 5:19 PM Arınç ÜNAL <arinc.unal@...nc9.com> wrote: >> >> On 14.09.2022 18:14, Rob Herring wrote: >>> On Wed, Sep 14, 2022 at 11:54:45AM +0300, Arınç ÜNAL wrote: >>>> Add syscon as a constant string on the compatible property as it's required >>>> for the SoC to work. Update the example accordingly. >>> >>> It's not required. It's required to automagically create a regmap. That >>> can be done yourself as well. The downside to adding 'syscon' is it >>> requires a DT update. Maybe that's fine for this platform? I don't know. >> >> My GB-PC2 won't boot without syscon on mt7621.dtsi. This string was >> always there on the memory controller node on mt7621.dtsi. > > The string was introduced because the mt7621 clock driver needs to > read some registers creating a regmap from the syscon. The bindings > were added before the clock driver was properly mainlined and at first > the clock driver was using ralink architecture dependent operations > rt_memc_* defined in > 'arch/mips/include/asm/mach-ralink/ralink_regs.h'. I forgot to update > the mem controller binding when memc became a syscon so I think this > patch is correct. I also think the sample should use 'syscon' in the > node name instead of memory-controller. Will change to syscon in v2. Arınç
Powered by blists - more mailing lists