netdev - Re: [PATCH v2 net-next 05/10] mips: dts: ralink: mt7621: fix some dtc warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMhs-H87WFJJgFEkZ7XeBsBMJKfZdzUjVChqb3_KbRqPodwTrg@mail.gmail.com>
Date:   Thu, 15 Sep 2022 09:17:44 +0200
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>, erkin.bozoglu@...ont.com,
        netdev <netdev@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, linux-arm-kernel@...ts.infradead.org,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "open list:MIPS" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH v2 net-next 05/10] mips: dts: ralink: mt7621: fix some dtc warnings

Hi Arinc,

On Thu, Sep 15, 2022 at 8:56 AM Arınç ÜNAL <arinc.unal@...nc9.com> wrote:
>
> Fix the dtc warnings below.
>
> uartlite@c00: $nodename:0: 'uartlite@...' does not match '^serial(@.*)?$'
>         From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/serial/8250.yaml
> uartlite@c00: Unevaluated properties are not allowed ('clock-names' was unexpected)
>         From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/serial/8250.yaml
> sdhci@...30000: $nodename:0: 'sdhci@...30000' does not match '^mmc(@.*)?$'
>         From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> sdhci@...30000: Unevaluated properties are not allowed ('bus-width', 'cap-mmc-highspeed', 'cap-sd-highspeed', 'disable-wp', 'max-frequency', 'vmmc-supply', 'vqmmc-supply' were unexpected)
>         From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> xhci@...c0000: $nodename:0: 'xhci@...c0000' does not match '^usb(@.*)?'
>         From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> xhci@...c0000: compatible: ['mediatek,mt8173-xhci'] is too short
>         From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> switch0@0: $nodename:0: 'switch0@0' does not match '^(ethernet-)?switch(@.*)?$'
>         From schema: /home/arinc9/Documents/linux/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
> port@1: status:0: 'off' is not one of ['okay', 'disabled', 'reserved']
>         From schema: /home/arinc9/.local/lib/python3.10/site-packages/dtschema/schemas/dt-core.yaml
> port@2: status:0: 'off' is not one of ['okay', 'disabled', 'reserved']
>         From schema: /home/arinc9/.local/lib/python3.10/site-packages/dtschema/schemas/dt-core.yaml
> port@3: status:0: 'off' is not one of ['okay', 'disabled', 'reserved']
>         From schema: /home/arinc9/.local/lib/python3.10/site-packages/dtschema/schemas/dt-core.yaml
>
> - Change "uartlite: uartlite@c00" to "serial0: serial@c00" and remove the
> aliases node.
> - Remove "clock-names" from the serial0 node. The property doesn't exist on
> the 8250.yaml schema.
> - Change "sdhci: sdhci@...30000" to "mmc: mmc@...30000".
> - Change "xhci: xhci@...c0000" to "usb: usb@...c0000".
> - Add "mediatek,mtk-xhci" as the second compatible string on the usb node.
> - Change "switch0: switch0@0" to "switch0: switch@0"
> - Change "off" to "disabled" for disabled nodes.
>
> Remaining warnings are caused by the lack of json-schema documentation.

The followings needs to be ported to yaml schema but exist in its
previous txt format:

>
> /cpuintc: failed to match any schema with compatible: ['mti,cpu-interrupt-controller']

https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/mips/cpu_irq.txt#L13

> /palmbus@...00000/wdt@100: failed to match any schema with compatible: ['mediatek,mt7621-wdt']

https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/watchdog/mt7621-wdt.txt#L4

> /palmbus@...00000/i2c@900: failed to match any schema with compatible: ['mediatek,mt7621-i2c']

https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/i2c/i2c-mt7621.txt#L6

> /palmbus@...00000/spi@b00: failed to match any schema with compatible: ['ralink,mt7621-spi']

https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/spi/spi-mt7621.txt#L5

> /ethernet@...00000: failed to match any schema with compatible: ['mediatek,mt7621-eth']

https://elixir.bootlin.com/linux/v6.0-rc5/source/Documentation/devicetree/bindings/net/ralink,rt2880-net.txt#L15

>
> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> ---
>  .../boot/dts/ralink/mt7621-gnubee-gb-pc1.dts  |  2 +-
>  .../boot/dts/ralink/mt7621-gnubee-gb-pc2.dts  |  2 +-
>  arch/mips/boot/dts/ralink/mt7621.dtsi         | 28 ++++++++-----------
>  3 files changed, 13 insertions(+), 19 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@...il.com>