netdev - Re: [PATCH net-next 06/12] net: dpaa2-eth: update the dpni_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 17 Sep 2022 04:22:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ioana Ciornei <ioana.ciornei@....com>, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, ast@...nel.org, daniel@...earbox.net,
        hawk@...nel.org, john.fastabend@...il.com,
        Ioana Ciornei <ioana.ciornei@....com>
Subject: Re: [PATCH net-next 06/12] net: dpaa2-eth: update the
 dpni_set_pools() API to support per QDBIN pools

Hi Ioana,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Ioana-Ciornei/net-dpaa2-eth-AF_XDP-zero-copy-support/20220913-023809
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 169ccf0e40825d9e465863e4707d8e8546d3c3cb
config: powerpc-randconfig-s043-20220915
compiler: powerpc-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/268938d5b176b743e9ffb9e46a58225be8ae7392
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ioana-Ciornei/net-dpaa2-eth-AF_XDP-zero-copy-support/20220913-023809
        git checkout 268938d5b176b743e9ffb9e46a58225be8ae7392
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/freescale/dpaa2/dpni.c:178:45: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] dpbp_id @@     got restricted __le16 [usertype] @@
   drivers/net/ethernet/freescale/dpaa2/dpni.c:178:45: sparse:     expected unsigned short [usertype] dpbp_id
   drivers/net/ethernet/freescale/dpaa2/dpni.c:178:45: sparse:     got restricted __le16 [usertype]

vim +178 drivers/net/ethernet/freescale/dpaa2/dpni.c

   148	
   149	/**
   150	 * dpni_set_pools() - Set buffer pools configuration
   151	 * @mc_io:	Pointer to MC portal's I/O object
   152	 * @cmd_flags:	Command flags; one or more of 'MC_CMD_FLAG_'
   153	 * @token:	Token of DPNI object
   154	 * @cfg:	Buffer pools configuration
   155	 *
   156	 * mandatory for DPNI operation
   157	 * warning:Allowed only when DPNI is disabled
   158	 *
   159	 * Return:	'0' on Success; Error code otherwise.
   160	 */
   161	int dpni_set_pools(struct fsl_mc_io *mc_io,
   162			   u32 cmd_flags,
   163			   u16 token,
   164			   const struct dpni_pools_cfg *cfg)
   165	{
   166		struct fsl_mc_command cmd = { 0 };
   167		struct dpni_cmd_set_pools *cmd_params;
   168		int i;
   169	
   170		/* prepare command */
   171		cmd.header = mc_encode_cmd_header(DPNI_CMDID_SET_POOLS,
   172						  cmd_flags,
   173						  token);
   174		cmd_params = (struct dpni_cmd_set_pools *)cmd.params;
   175		cmd_params->num_dpbp = cfg->num_dpbp;
   176		cmd_params->pool_options = cfg->pool_options;
   177		for (i = 0; i < DPNI_MAX_DPBP; i++) {
 > 178			cmd_params->pool[i].dpbp_id =
   179				cpu_to_le16(cfg->pools[i].dpbp_id);
   180			cmd_params->pool[i].priority_mask =
   181				cfg->pools[i].priority_mask;
   182			cmd_params->buffer_size[i] =
   183				cpu_to_le16(cfg->pools[i].buffer_size);
   184			cmd_params->backup_pool_mask |=
   185				DPNI_BACKUP_POOL(cfg->pools[i].backup_pool, i);
   186		}
   187	
   188		/* send command to mc*/
   189		return mc_send_command(mc_io, &cmd);
   190	}
   191	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (243992 bytes)