[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+NMeC97ehoQAM4_Kh9mxw1aWob0KZLOxof_-dHQ-wMes9jOEQ@mail.gmail.com>
Date: Fri, 16 Sep 2022 17:36:23 -0300
From: Victor Nogueira <victor@...atatu.com>
To: Zhengchao Shao <shaozhengchao@...wei.com>
Cc: netdev@...r.kernel.org, linux-kselftest@...r.kernel.org,
jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, toke@...e.dk, vinicius.gomes@...el.com,
stephen@...workplumber.org, shuah@...nel.org,
zhijianx.li@...el.com, weiyongjun1@...wei.com,
yuehaibing@...wei.com
Subject: Re: [PATCH net-next 05/18] selftests/tc-testings: add selftests for
cbs qdisc
On Fri, Sep 16, 2022 at 12:04 AM Zhengchao Shao
<shaozhengchao@...wei.com> wrote:
>
> Test 1820: Create CBS with default setting
> Test 1532: Create CBS with hicredit setting
> Test 2078: Create CBS with locredit setting
> Test 0482: Create CBS with sendslope setting
> Test e8f3: Create CBS with multiple setting
> Test 23c9: Replace CBS with sendslope setting
> Test a07a: Change CBS with idleslope setting
> Test 43b3: Delete CBS with handle
> Test 9472: Show CBS class
>
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
> .../tc-testing/tc-tests/qdiscs/cbs.json | 234 ++++++++++++++++++
> 1 file changed, 234 insertions(+)
> create mode 100644 tools/testing/selftests/tc-testing/tc-tests/qdiscs/cbs.json
>
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/cbs.json b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/cbs.json
> new file mode 100644
> index 000000000000..06618d2c3700
> --- /dev/null
> +++ b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/cbs.json
> @@ -0,0 +1,234 @@
> +[
> + {
> + "id": "1820",
> + "name": "Create CBS with default setting",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true"
> + ],
> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cbs",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $DUMMY",
> + "matchPattern": "qdisc cbs 1: root refcnt [0-9]+ hicredit 0 locredit 0 sendslope 0 idleslope 0 offload 0.*qdisc pfifo 0: parent 1: limit 1000p",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DUMMY handle 1: root",
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + },
> + {
> + "id": "1532",
> + "name": "Create CBS with hicredit setting",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true"
> + ],
> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cbs hicredit 64",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $DUMMY",
> + "matchPattern": "qdisc cbs 1: root refcnt [0-9]+ hicredit 64 locredit 0 sendslope 0 idleslope 0 offload 0.*qdisc pfifo 0: parent 1: limit 1000p",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DUMMY handle 1: root",
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + },
> + {
> + "id": "2078",
> + "name": "Create CBS with locredit setting",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true"
> + ],
> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cbs locredit 10",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $DUMMY",
> + "matchPattern": "qdisc cbs 1: root refcnt [0-9]+ hicredit 0 locredit 10 sendslope 0 idleslope 0 offload 0.*qdisc pfifo 0: parent 1: limit 1000p",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DUMMY handle 1: root",
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + },
> + {
> + "id": "0482",
> + "name": "Create CBS with sendslope setting",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true"
> + ],
> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cbs sendslope 888",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $DUMMY",
> + "matchPattern": "qdisc cbs 1: root refcnt [0-9]+ hicredit 0 locredit 0 sendslope 888 idleslope 0 offload 0.*qdisc pfifo 0: parent 1: limit 1000p",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DUMMY handle 1: root",
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + },
> + {
> + "id": "0482",
Be careful, you are using ID 0482 in the previous test case.
> + "name": "Create CBS with idleslope setting",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true"
> + ],
> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cbs idleslope 666",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $DUMMY",
> + "matchPattern": "qdisc cbs 1: root refcnt [0-9]+ hicredit 0 locredit 0 sendslope 0 idleslope 666 offload 0.*qdisc pfifo 0: parent 1: limit 1000p",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DUMMY handle 1: root",
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + },
> + {
> + "id": "e8f3",
> + "name": "Create CBS with multiple setting",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true"
> + ],
> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cbs hicredit 10 locredit 75 sendslope 2 idleslope 666",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $DUMMY",
> + "matchPattern": "qdisc cbs 1: root refcnt [0-9]+ hicredit 10 locredit 75 sendslope 2 idleslope 666 offload 0.*qdisc pfifo 0: parent 1: limit 1000p",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DUMMY handle 1: root",
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + },
> + {
> + "id": "23c9",
> + "name": "Replace CBS with sendslope setting",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true",
> + "$TC qdisc add dev $DUMMY handle 1: root cbs idleslope 666"
> + ],
> + "cmdUnderTest": "$TC qdisc replace dev $DUMMY handle 1: root cbs sendslope 10",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $DUMMY",
> + "matchPattern": "qdisc cbs 1: root refcnt [0-9]+ hicredit 0 locredit 0 sendslope 10 idleslope 0 offload 0.*qdisc pfifo 0: parent 1: limit 1000p",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DUMMY handle 1: root",
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + },
> + {
> + "id": "a07a",
> + "name": "Change CBS with idleslope setting",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true",
> + "$TC qdisc add dev $DUMMY handle 1: root cbs idleslope 666"
> + ],
> + "cmdUnderTest": "$TC qdisc change dev $DUMMY handle 1: root cbs idleslope 1",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $DUMMY",
> + "matchPattern": "qdisc cbs 1: root refcnt [0-9]+ hicredit 0 locredit 0 sendslope 0 idleslope 1 offload 0.*qdisc pfifo 0: parent 1: limit 1000p",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DUMMY handle 1: root",
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + },
> + {
> + "id": "43b3",
> + "name": "Delete CBS with handle",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true",
> + "$TC qdisc add dev $DUMMY handle 1: root cbs idleslope 666"
> + ],
> + "cmdUnderTest": "$TC qdisc del dev $DUMMY handle 1: root",
> + "expExitCode": "0",
> + "verifyCmd": "$TC qdisc show dev $DUMMY",
> + "matchPattern": "qdisc cbs 1: root refcnt [0-9]+ hicredit 0 locredit 0 sendslope 0 idleslope 1 offload 0.*qdisc pfifo 0: parent 1: limit 1000p",
> + "matchCount": "0",
> + "teardown": [
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + },
> + {
> + "id": "9472",
> + "name": "Show CBS class",
> + "category": [
> + "qdisc",
> + "cbs"
> + ],
> + "plugins": {
> + "requires": "nsPlugin"
> + },
> + "setup": [
> + "$IP link add dev $DUMMY type dummy || /bin/true"
> + ],
> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cbs",
> + "expExitCode": "0",
> + "verifyCmd": "$TC class show dev $DUMMY",
> + "matchPattern": "class cbs 1:[0-9]+ parent 1:",
> + "matchCount": "1",
> + "teardown": [
> + "$TC qdisc del dev $DUMMY handle 1: root",
> + "$IP link del dev $DUMMY type dummy"
> + ]
> + }
> +]
> --
> 2.17.1
>
Powered by blists - more mailing lists