| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 17 Sep 2022 09:48:34 +0800
From: shaozhengchao <shaozhengchao@...wei.com>
To: Victor Nogueira <victor@...atatu.com>
CC: <netdev@...r.kernel.org>, <cake@...ts.bufferbloat.net>,
<linux-kselftest@...r.kernel.org>, <jhs@...atatu.com>,
<xiyou.wangcong@...il.com>, <jiri@...nulli.us>,
<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
<pabeni@...hat.com>, <toke@...e.dk>, <vinicius.gomes@...el.com>,
<stephen@...workplumber.org>, <shuah@...nel.org>,
<zhijianx.li@...el.com>, <weiyongjun1@...wei.com>,
<yuehaibing@...wei.com>
Subject: Re: [PATCH net-next 03/18] selftests/tc-testings: add selftests for
cake qdisc
On 2022/9/17 4:32, Victor Nogueira wrote:
> On Fri, Sep 16, 2022 at 12:04 AM Zhengchao Shao
> <shaozhengchao@...wei.com> wrote:
>>
>> Test 1212: Create CAKE with default setting
>> Test 3241: Create CAKE with bandwidth limit
>> Test c940: Create CAKE with autorate-ingress flag
>> Test 2310: Create CAKE with rtt time
>> Test 2385: Create CAKE with besteffort flag
>> Test a032: Create CAKE with diffserv8 flag
>> Test 2349: Create CAKE with diffserv4 flag
>> Test 8472: Create CAKE with flowblind flag
>> Test 2341: Create CAKE with dsthost and nat flag
>> Test 5134: Create CAKE with wash flag
>> Test 2302: Create CAKE with flowblind and no-split-gso flag
>> Test 0768: Create CAKE with dual-srchost and ack-filter flag
>> Test 0238: Create CAKE with dual-dsthost and ack-filter-aggressive flag
>> Test 6573: Create CAKE with memlimit and ptm flag
>> Test 2436: Create CAKE with fwmark and atm flag
>> Test 3984: Create CAKE with overhead and mpu
>> Test 2342: Create CAKE with conservative and ingress flag
>> Test 2313: Change CAKE with mpu
>> Test 4365: Show CAKE class
>>
>> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>> ---
>> .../tc-testing/tc-tests/qdiscs/cake.json | 488 ++++++++++++++++++
>> 1 file changed, 488 insertions(+)
>> create mode 100644 tools/testing/selftests/tc-testing/tc-tests/qdiscs/cake.json
>>
>> diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/cake.json b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/cake.json
>> new file mode 100644
>> index 000000000000..11ca18bab721
>> --- /dev/null
>> +++ b/tools/testing/selftests/tc-testing/tc-tests/qdiscs/cake.json
>> @@ -0,0 +1,488 @@
>> +[
>> + {
>> + "id": "1212",
>> + "name": "Create CAKE with default setting",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "3241",
>> + "name": "Create CAKE with bandwidth limit",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake bandwidth 1000",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth 1Kbit diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "c940",
>> + "name": "Create CAKE with autorate-ingress flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake autorate-ingress",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited autorate-ingress diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2310",
>> + "name": "Create CAKE with rtt time",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake rtt 200",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 200us raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2385",
>> + "name": "Create CAKE with besteffort flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake besteffort",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited besteffort triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "a032",
>> + "name": "Create CAKE with diffserv8 flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake diffserv8",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv8 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2349",
>> + "name": "Create CAKE with diffserv4 flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake diffserv4",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv4 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "8472",
>> + "name": "Create CAKE with flowblind flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake flowblind",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 flowblind nonat nowash no-ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2341",
>> + "name": "Create CAKE with dsthost and nat flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake dsthost nat",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 dsthost nat nowash no-ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "5134",
>> + "name": "Create CAKE with wash flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake hosts wash",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 hosts nonat wash no-ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2302",
>> + "name": "Create CAKE with flowblind and no-split-gso flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake flowblind no-split-gso",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 flowblind nonat nowash no-ack-filter no-split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "0768",
>> + "name": "Create CAKE with dual-srchost and ack-filter flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake dual-srchost ack-filter",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 dual-srchost nonat nowash ack-filter split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "0238",
>> + "name": "Create CAKE with dual-dsthost and ack-filter-aggressive flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake dual-dsthost ack-filter-aggressive",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 dual-dsthost nonat nowash ack-filter-aggressive split-gso rtt 100ms raw overhead",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "6573",
>> + "name": "Create CAKE with memlimit and ptm flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake memlimit 10000 ptm",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw ptm overhead 0 memlimit 10000b",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2436",
>> + "name": "Create CAKE with fwmark and atm flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake fwmark 8 atm",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms raw atm overhead 0 fwmark 0x8",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "3984",
>> + "name": "Create CAKE with overhead and mpu",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake overhead 128 mpu 256",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms noatm overhead 128 mpu 256",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2342",
>> + "name": "Create CAKE with conservative and ingress flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake conservative ingress",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 triple-isolate nonat nowash ingress no-ack-filter split-gso rtt 100ms atm overhead 48",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2342",
>
> Be careful, you are using ID 2342 for 3 test cases in this file.
> Each test case must have a unique ID.
>
>
>
Hi Victor:
Thank you for your review. My mistake. I will check more
carefully, and test again. Then send V2.
Zhengchao Shao
>> + "name": "Delete CAKE with conservative and ingress flag",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true",
>> + "$TC qdisc add dev $DUMMY handle 1: root cake conservative ingress"
>> + ],
>> + "cmdUnderTest": "$TC qdisc del dev $DUMMY handle 1: root",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 triple-isolate nonat nowash ingress no-ack-filter split-gso rtt 100ms atm overhead 48",
>> + "matchCount": "0",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2342",
>> + "name": "Replace CAKE with mpu",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true",
>> + "$TC qdisc add dev $DUMMY handle 1: root cake overhead 128 mpu 256"
>> + ],
>> + "cmdUnderTest": "$TC qdisc replace dev $DUMMY handle 1: root cake mpu 128",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms noatm overhead 128 mpu 128",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "2313",
>> + "name": "Change CAKE with mpu",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true",
>> + "$TC qdisc add dev $DUMMY handle 1: root cake overhead 128 mpu 256"
>> + ],
>> + "cmdUnderTest": "$TC qdisc change dev $DUMMY handle 1: root cake mpu 128",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC qdisc show dev $DUMMY",
>> + "matchPattern": "qdisc cake 1: root refcnt [0-9]+ bandwidth unlimited diffserv3 triple-isolate nonat nowash no-ack-filter split-gso rtt 100ms noatm overhead 128 mpu 128",
>> + "matchCount": "1",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + },
>> + {
>> + "id": "4365",
>> + "name": "Show CAKE class",
>> + "category": [
>> + "qdisc",
>> + "cake"
>> + ],
>> + "plugins": {
>> + "requires": "nsPlugin"
>> + },
>> + "setup": [
>> + "$IP link add dev $DUMMY type dummy || /bin/true"
>> + ],
>> + "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root cake",
>> + "expExitCode": "0",
>> + "verifyCmd": "$TC class show dev $DUMMY",
>> + "matchPattern": "class cake",
>> + "matchCount": "0",
>> + "teardown": [
>> + "$TC qdisc del dev $DUMMY handle 1: root",
>> + "$IP link del dev $DUMMY type dummy"
>> + ]
>> + }
>> +]
>> --
>> 2.17.1
>>
Powered by blists - more mailing lists