netdev - [PATCH v1] net/ethtool/tunnels: Check return value of nla_nest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220918015454.672485-1-floridsleeves@gmail.com>
Date:   Sat, 17 Sep 2022 18:54:54 -0700
From:   Li Zhong <floridsleeves@...il.com>
To:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc:     pabeni@...hat.com, kuba@...nel.org, edumazet@...gle.com,
        davem@...emloft.net, Li Zhong <floridsleeves@...il.com>
Subject: [PATCH v1] net/ethtool/tunnels: Check return value of nla_nest_start()

Return value of nla_nest_start() could be null on error. We need to
check it before we pass entry to nla_nest_end().

Signed-off-by: Li Zhong <floridsleeves@...il.com>
---
 net/ethtool/tunnels.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ethtool/tunnels.c b/net/ethtool/tunnels.c
index efde33536687..2d6b03a35dd9 100644
--- a/net/ethtool/tunnels.c
+++ b/net/ethtool/tunnels.c
@@ -140,7 +140,7 @@ ethnl_tunnel_info_fill_reply(const struct ethnl_req_info *req_base,
 		if (nla_put_be16(skb, ETHTOOL_A_TUNNEL_UDP_ENTRY_PORT,
 				 htons(IANA_VXLAN_UDP_PORT)) ||
 		    nla_put_u32(skb, ETHTOOL_A_TUNNEL_UDP_ENTRY_TYPE,
-				ilog2(UDP_TUNNEL_TYPE_VXLAN)))
+				ilog2(UDP_TUNNEL_TYPE_VXLAN)) || !entry)
 			goto err_cancel_entry;
 
 		nla_nest_end(skb, entry);
-- 
2.25.1