netdev - Re: [RFC PATCH net-next 1/2] net: sched: act_api: add helper macro for tcf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yyid37e8ddqU1NrG@pop-os.localdomain>
Date:   Mon, 19 Sep 2022 09:50:39 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     shaozhengchao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, bpf@...r.kernel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        jhs@...atatu.com, jiri@...nulli.us, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev,
        song@...nel.org, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        jolsa@...nel.org, weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [RFC PATCH net-next 1/2] net: sched: act_api: add helper macro
 for tcf_action in module and net init/exit

On Mon, Sep 19, 2022 at 07:07:22PM +0800, shaozhengchao wrote:
> 
> 
> On 2022/9/18 3:03, Cong Wang wrote:
> > On Fri, Sep 16, 2022 at 04:51:54PM +0800, Zhengchao Shao wrote:
> > > Helper macro for tcf_action that don't do anything special in module
> > > and net init/exit. This eliminates a lot of boilerplate. Each module
> > > may only use this macro once, and calling it replaces module/net_init()
> > > and module/net_exit().
> > > 
> > 
> > This looks over engineering to me. I don't think this reduces any code
> > size or help any readability.
> > 
> > Thanks.
> Hi Wang:
> 	Thank you for your review. I think this macro can simplify
> repeated code when adding action modules later.
> 

I don't think so, it hides the actual code in a less readable way. I'd
like to read the non-macro code.

Thanks.