netdev - Re: [PATCH v2] net: ethernet: altera: TSE: fix error return code in altera_tse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220919140951.3dcdcba7@kernel.org>
Date:   Mon, 19 Sep 2022 14:09:51 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sun Ke <sunke32@...wei.com>
Cc:     <joyce.ooi@...el.com>, <davem@...emloft.net>,
        <edumazet@...gle.com>, <pabeni@...hat.com>,
        <linux@...linux.org.uk>, <netdev@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH v2] net: ethernet: altera: TSE: fix error return code in
 altera_tse_probe()

On Fri, 9 Sep 2022 10:46:17 +0800 Sun Ke wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
> 
> Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Sun Ke <sunke32@...wei.com>

You must CC Maxime, who authored the change under Fixes,
and is most likely the best person to give us a review.
Please repost with the CC fixed.

> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index 89ae6d1623aa..3cf409bdb283 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
>  				       priv->phy_iface, &alt_tse_phylink_ops);
>  	if (IS_ERR(priv->phylink)) {
>  		dev_err(&pdev->dev, "failed to create phylink\n");
> +		ret = PTR_ERR(priv->phylink);
>  		goto err_init_phy;
>  	}
>