netdev - Re: [PATCH v2 net-next 03/10] net: dsa: allow the DSA master to be seen and changed through rtnetlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fb488a102d0738ab153bf133439dd64f09d096e.camel@redhat.com>
Date:   Tue, 20 Sep 2022 11:24:57 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Vladimir Oltean <vladimir.oltean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vladimir Oltean <olteanv@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>,
        Colin Foster <colin.foster@...advantage.com>,
        Roopa Prabhu <roopa@...dia.com>,
        Nikolay Aleksandrov <razor@...ckwall.org>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Marek Behún <kabel@...nel.org>,
        Ansuel Smith <ansuelsmth@...il.com>,
        DENG Qingfang <dqfext@...il.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Linus Walleij <linus.walleij@...aro.org>,
        Luiz Angelo Daros de Luca <luizluca@...il.com>,
        Felix Fietkau <nbd@....name>, John Crispin <john@...ozen.org>,
        Sean Wang <sean.wang@...iatek.com>,
        David Ahern <dsahern@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH v2 net-next 03/10] net: dsa: allow the DSA master to be
 seen and changed through rtnetlink

Hello,

On Sun, 2022-09-11 at 14:35 +0000, Vladimir Oltean wrote:
> On Sun, Sep 11, 2022 at 04:06:59AM +0300, Vladimir Oltean wrote:
> > +struct rtnl_link_ops dsa_link_ops __read_mostly = {
> > +	.kind			= "dsa",
> > +	.priv_size		= sizeof(struct dsa_port),
> > +	.maxtype		= IFLA_DSA_MAX,
> > +	.policy			= dsa_policy,
> > +	.changelink		= dsa_changelink,
> > +	.get_size		= dsa_get_size,
> > +	.fill_info		= dsa_fill_info,
> > +};
> 
> I forgot to apply Jakub's suggestion to set netns_refund = true.
> On the other hand, I think the patches are otherwise fine, and I
> wouldn't resend them, especially without any feedback. If there is no
> other feedback, can I fix this up through an incremental patch?

Since the delta should be minimal, we have a significant backlog, and
this LGTM, I'm going to apply the series as-is.

Please follow-up with the incremental fix, thanks,

Paolo