netdev - Re: [PATCH net 2/2] bonding: fix NULL deref in bond_rr_gen_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHn8xcnRXq95WB9YQW1JLgZtQ0ey0LedLKT=DYr025iyqjvhxw@mail.gmail.com>
Date:   Tue, 20 Sep 2022 12:08:56 +0200
From:   Jussi Maki <joamaki@...il.com>
To:     Jonathan Toppins <jtoppins@...hat.com>
Cc:     "netdev @ vger . kernel . org" <netdev@...r.kernel.org>,
        Jay Vosburgh <j.vosburgh@...il.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 2/2] bonding: fix NULL deref in bond_rr_gen_slave_id

On Tue, Sep 20, 2022 at 1:09 AM Jonathan Toppins <jtoppins@...hat.com> wrote:
>
> Fix a NULL dereference of the struct bonding.rr_tx_counter member because
> if a bond is initially created with an initial mode != zero (Round Robin)
> the memory required for the counter is never created and when the mode is
> changed there is never any attempt to verify the memory is allocated upon
> switching modes.

Thanks for the fix and sorry for missing the mode change path in the
original patch.

Acked-by: Jussi Maki <joamaki@...il.com>