netdev - Re: [net-next v8 2/3] net: ethernet: adi: Add ADIN1110 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 08:29:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     andrei.tachici@...d.acs.upb.ro
Cc:     linux-kernel@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com,
        linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, netdev@...r.kernel.org,
        vegard.nossum@...cle.com, joel@....id.au, l.stelmach@...sung.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        devicetree@...r.kernel.org
Subject: Re: [net-next v8 2/3] net: ethernet: adi: Add ADIN1110 support

On Tue, 13 Sep 2022 15:26:28 +0300 andrei.tachici@...d.acs.upb.ro wrote:
> +static int adin1110_port_get_port_parent_id(struct net_device *dev,
> +					    struct netdev_phys_item_id *ppid)
> +{
> +	struct adin1110_port_priv *port_priv = netdev_priv(dev);
> +	struct adin1110_priv *priv = port_priv->priv;
> +
> +	ppid->id_len = strnlen(priv->mii_bus_name, MII_BUS_ID_SIZE);
> +	memcpy(ppid->id, priv->mii_bus_name, ppid->id_len);

gcc 8.5 complains about overflow here, MII_BUS_ID_SIZE is larger 
than MAX_PHYS_ITEM_ID_LEN, i.e. the length of ppid->id.

Please fix this up, the build bots are gonna get angry.