netdev - Re: [PATCH net] sfc: fix TX channel offset when using legacy interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Sep 2022 01:20:14 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Íñigo Huguet <ihuguet@...hat.com>@ci.codeaurora.org
Cc:     ecree.xilinx@...il.com, habetsm.xilinx@...il.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org, tizhao@...hat.com
Subject: Re: [PATCH net] sfc: fix TX channel offset when using legacy interrupts

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 14 Sep 2022 12:36:48 +0200 you wrote:
> In legacy interrupt mode the tx_channel_offset was hardcoded to 1, but
> that's not correct if efx_sepparate_tx_channels is false. In that case,
> the offset is 0 because the tx queues are in the single existing channel
> at index 0, together with the rx queue.
> 
> Without this fix, as soon as you try to send any traffic, it tries to
> get the tx queues from an uninitialized channel getting these errors:
>   WARNING: CPU: 1 PID: 0 at drivers/net/ethernet/sfc/tx.c:540 efx_hard_start_xmit+0x12e/0x170 [sfc]
>   [...]
>   RIP: 0010:efx_hard_start_xmit+0x12e/0x170 [sfc]
>   [...]
>   Call Trace:
>    <IRQ>
>    dev_hard_start_xmit+0xd7/0x230
>    sch_direct_xmit+0x9f/0x360
>    __dev_queue_xmit+0x890/0xa40
>   [...]
>   BUG: unable to handle kernel NULL pointer dereference at 0000000000000020
>   [...]
>   RIP: 0010:efx_hard_start_xmit+0x153/0x170 [sfc]
>   [...]
>   Call Trace:
>    <IRQ>
>    dev_hard_start_xmit+0xd7/0x230
>    sch_direct_xmit+0x9f/0x360
>    __dev_queue_xmit+0x890/0xa40
>   [...]
> 
> [...]

Here is the summary with links:
  - [net] sfc: fix TX channel offset when using legacy interrupts
    https://git.kernel.org/netdev/net/c/f232af429565

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html