netdev - Re: [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220920113623.2f041e80@kernel.org>
Date:   Tue, 20 Sep 2022 11:36:23 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Li Zhong <floridsleeves@...il.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        intel-wired-lan@...ts.osuosl.org, pabeni@...hat.com,
        edumazet@...gle.com, davem@...emloft.net,
        anthony.l.nguyen@...el.com, jesse.brandeburg@...el.com
Subject: Re: [PATCH v2] drivers/net/ethernet/intel/e100: check the return
 value of e100_exec_cmd()

On Fri, 16 Sep 2022 17:10:27 -0700 Li Zhong wrote:
> Check the return value of e100_exec_cmd() which could return error code
> when execution fails.

You need to provide more detailed analysis in the commit message.
Right now it looks like you're just blindly finding cases where
return value is not checked and adding error checks. This is as
likely to fix something as it is to break.