lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 20 Sep 2022 14:01:19 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Vladimir Oltean <vladimir.oltean@....com> Cc: netdev@...r.kernel.org, Vinicius Costa Gomes <vinicius.gomes@...el.com>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, Jiri Pirko <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Voon Weifeng <weifeng.voon@...el.com>, Vladimir Oltean <olteanv@...il.com>, Kurt Kanzenbach <kurt@...utronix.de>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 net-next 7/7] net/sched: taprio: replace safety precautions with comments On Thu, 15 Sep 2022 13:50:46 +0300 Vladimir Oltean wrote: > The WARN_ON_ONCE() checks introduced in commit 13511704f8d7 ("net: > taprio offload: enforce qdisc to netdev queue mapping") take a small > toll on performance, but otherwise, the conditions are never expected to > happen. Replace them with comments, such that the information is still > conveyed to developers. Another option is DEBUG_NET_WARN_ON_ONCE() FWIW, you probably know..
Powered by blists - more mailing lists