netdev - Re: [PATCH v2] net: dsa: mt7530: add support for in-band link status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yyo+qallmqd2/FG8@makrotopia.org>
Date:   Tue, 20 Sep 2022 23:28:57 +0100
From:   Daniel Golle <daniel@...rotopia.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Russell King <linux@...linux.org.uk>,
        linux-mediatek@...ts.infradead.org, netdev@...r.kernel.org,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Alexander 'lynxis' Couzens <lynxis@...0.eu>
Subject: Re: [PATCH v2] net: dsa: mt7530: add support for in-band link status

On Mon, Sep 19, 2022 at 06:36:22PM -0700, Jakub Kicinski wrote:
> On Sun, 11 Sep 2022 21:45:30 +0100 Daniel Golle wrote:
> >  static void mt7531_pcs_get_state(struct phylink_pcs *pcs,
> >  				 struct phylink_link_state *state)
> >  {
> >  	struct mt7530_priv *priv = pcs_to_mt753x_pcs(pcs)->priv;
> >  	int port = pcs_to_mt753x_pcs(pcs)->port;
> > +	unsigned int val;
> >  
> > -	if (state->interface == PHY_INTERFACE_MODE_SGMII)
> > +	if (state->interface == PHY_INTERFACE_MODE_SGMII) {
> >  		mt7531_sgmii_pcs_get_state_an(priv, port, state);
> > -	else
> > -		state->link = false;
> > +		return;
> > +	} else if ((state->interface == PHY_INTERFACE_MODE_1000BASEX) ||
> > +		   (state->interface == PHY_INTERFACE_MODE_2500BASEX)) {
> > +		mt7531_sgmii_pcs_get_state_inband(priv, port, state);
> > +		return;
> > +	}
> > +
> > +	state->link = false;
> 
> drivers/net/dsa/mt7530.c:3040:15: warning: unused variable 'val' [-Wunused-variable]
>         unsigned int val;
>                      ^

Oops, forgot that one there. Just sent out v3 with this fixed and
an_complete handled more decently.

Thank you for the review!