[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220920164435.55c026d3@kernel.org>
Date: Tue, 20 Sep 2022 16:44:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
kernel@...gutronix.de, Yasuaki Ishimatsu <yasu.isimatu@...il.com>
Subject: Re: [PATCH] net: fjes: Reorder symbols to get rid of a few forward
declarations
On Sun, 18 Sep 2022 00:51:42 +0200 Uwe Kleine-König wrote:
> Quite a few of the functions and other symbols defined in this driver had
> forward declarations. They can all be dropped after reordering them.
>
> This saves a few lines of code and reduces code duplication.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Any reason why do this? There's a ton of cobwebbed code with pointless
forward declarations. Do you have the HW and plan to work on the driver?
Powered by blists - more mailing lists