netdev - Re:Re: [PATCH] net: marvell: Fix refcounting bugs in prestera_port_sfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5722f6ba.6204.1835f4924aa.Coremail.windhl@126.com>
Date:   Wed, 21 Sep 2022 17:02:52 +0800 (CST)
From:   "Liang He" <windhl@....com>
To:     "Jakub Kicinski" <kuba@...nel.org>
Cc:     tchornyi@...vell.com, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, linux@...linux.org.uk, netdev@...r.kernel.org
Subject: Re:Re: [PATCH] net: marvell: Fix refcounting bugs in
 prestera_port_sfp_bind()


At 2022-09-21 08:45:29, "Jakub Kicinski" <kuba@...nel.org> wrote:
>On Thu, 15 Sep 2022 12:06:55 +0800 Liang He wrote:
>> In prestera_port_sfp_bind(), there are two refcounting bugs:
>> (1) we should call of_node_get() before of_find_node_by_name() as
>> it will automaitcally decrease the refcount of 'from' argument;
>> (2) we should call of_node_put() for the break of the iteration
>> for_each_child_of_node() as it will automatically increase and
>> decrease the 'child'.
>> 
>> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
>> Signed-off-by: Liang He <windhl@....com>
>
>Please repost and CC all the authors of the patch under Fixes.

Thanks for your reply, Jakub

As I was the only one author, you mean following tag format:

""
Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
CC: Liang He <windhl@....com>
Signed-off-by: Liang He <windhl@....com>
""

If there is anything wrong, sorry for this trouble.

Thanks,

Liang