netdev - Re: [RFCv8 PATCH net-next 02/55] net: replace general features macroes with global netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Sep 2022 18:01:16 +0800
From:   "shenjian (K)" <shenjian15@...wei.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <ecree.xilinx@...il.com>, <andrew@...n.ch>,
        <hkallweit1@...il.com>, <alexandr.lobakin@...el.com>,
        <saeed@...nel.org>, <leon@...nel.org>, <netdev@...r.kernel.org>,
        <linuxarm@...wei.com>
Subject: Re: [RFCv8 PATCH net-next 02/55] net: replace general features
 macroes with global netdev_features variables



在 2022/9/21 14:33, shenjian (K) 写道:
>
>
> 在 2022/9/21 4:12, Jakub Kicinski 写道:
>> On Sun, 18 Sep 2022 09:42:43 +0000 Jian Shen wrote:
>>> -#define NETIF_F_NEVER_CHANGE (NETIF_F_VLAN_CHALLENGED | \
>>> -                 NETIF_F_LLTX | NETIF_F_NETNS_LOCAL)
>>> +#define NETIF_F_NEVER_CHANGE    netdev_never_change_features
>> We shouldn't be changing all these defines here, because that breaks
>> the build AFAIU.
> ok, will keep them until remove the __NETIF_F(name) macro.
>
But I don't see how it break build. Do you mean the definition of

WG_NETDEV_FEATURES in drivers/net/wireguard/device.c ？

>
>>   Can we not use the lowercase names going forward?
>> .
> ok
>
> .
>