netdev - Re: [PATCH net-next v2] net/ethtool/tunnels: check the return value of nla_nest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220921060729.7443f3d2@kernel.org>
Date:   Wed, 21 Sep 2022 06:07:29 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Li Zhong <floridsleeves@...il.com>
Cc:     netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com,
        davem@...emloft.net
Subject: Re: [PATCH net-next v2] net/ethtool/tunnels: check the return value
 of nla_nest_start()

On Wed, 21 Sep 2022 01:30:04 -0700 Li Zhong wrote:
> Subject: [PATCH net-next v2] net/ethtool/tunnels: check the return value of nla_nest_start()

Please update the subject to follow the standard kernel convention.
The prefix should be something like

  ethtool: tunnels:

or just

  ethtool:

> Check the return value of nla_nest_start(). When starting the entry
> level nested attributes, if the tailroom of socket buffer is
> insufficient to store the attribute header and payload, the return value
> will be NULL and we should check it. If it is NULL, go to the
> error_cancel_entry label to do error handling.

Better but don't explain what the patch does but lean more into the
assessment of the situation. The last sentence is unnecessary, but
you should include an explanation if there is any _actual_ bug here.
Can something crash or misbehave?

> v2: error handling jump to error_cancel_entry, more details in commit 
> meesage

This should go under the --- separator