netdev - Re:Re: [PATCH] net: marvell: Fix refcounting bugs in prestera_port_sfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <31763e3d.79d2.183603a4e29.Coremail.windhl@126.com>
Date:   Wed, 21 Sep 2022 21:26:17 +0800 (CST)
From:   "Liang He" <windhl@....com>
To:     "Jakub Kicinski" <kuba@...nel.org>
Cc:     tchornyi@...vell.com, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, linux@...linux.org.uk, netdev@...r.kernel.org
Subject: Re:Re: [PATCH] net: marvell: Fix refcounting bugs in
 prestera_port_sfp_bind()




At 2022-09-21 20:36:35, "Jakub Kicinski" <kuba@...nel.org> wrote:
>On Wed, 21 Sep 2022 17:02:52 +0800 (CST) Liang He wrote:
>> At 2022-09-21 08:45:29, "Jakub Kicinski" <kuba@...nel.org> wrote:
>> >On Thu, 15 Sep 2022 12:06:55 +0800 Liang He wrote:  
>> >> In prestera_port_sfp_bind(), there are two refcounting bugs:
>> >> (1) we should call of_node_get() before of_find_node_by_name() as
>> >> it will automaitcally decrease the refcount of 'from' argument;
>> >> (2) we should call of_node_put() for the break of the iteration
>> >> for_each_child_of_node() as it will automatically increase and
>> >> decrease the 'child'.
>> >> 
>> >> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
>> >> Signed-off-by: Liang He <windhl@....com>  
>> >
>> >Please repost and CC all the authors of the patch under Fixes.  
>> 
>> Thanks for your reply, Jakub
>> 
>> As I was the only one author, you mean following tag format:
>> 
>> ""
>> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
>> CC: Liang He <windhl@....com>
>> Signed-off-by: Liang He <windhl@....com>
>
>No, no, CC the authors of the patch under fixes, which is to say -
>the patch which introduced the problem. The fixes tag you have is:
>
>Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
>
>so:
>
>commit 52323ef75414d60b17f683076833eb55a6bffa2b
>Author: Oleksandr Mazur <oleksandr.mazur@...ision.eu>
>Date:   Tue Jul 19 13:57:16 2022 +0300
>
>    net: marvell: prestera: add phylink support
>    
>    For SFP port prestera driver will use kernel
>    phylink infrastucture to configure port mode based on
>    the module that has beed inserted
>    
>    Co-developed-by: Yevhen Orlov <yevhen.orlov@...ision.eu>
>    Signed-off-by: Yevhen Orlov <yevhen.orlov@...ision.eu>
>    Co-developed-by: Taras Chornyi <taras.chornyi@...ision.eu>
>    Signed-off-by: Taras Chornyi <taras.chornyi@...ision.eu>
>    Signed-off-by: Oleksandr Mazur <oleksandr.mazur@...ision.eu>
>    Signed-off-by: David S. Miller <davem@...emloft.net>
>

>I was asking to also CC Yevhen and Oleksandr. Taras seems already CCed.


Thanks very much, I will follow this rule in my future patches.

Liang