netdev - Re: [PATCH net-next V2 07/17] net/mlx5: Add MACsec offload Tx command support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALHRZurXmiYtK-vW6efG=QwdF7h1BhJn8E5e60rg1KfFfmhnDw@mail.gmail.com>
Date:   Wed, 21 Sep 2022 19:13:43 +0530
From:   sundeep subbaraya <sundeep.lkml@...il.com>
To:     Antoine Tenart <atenart@...nel.org>
Cc:     Raed Salem <raeds@...dia.com>, Saeed Mahameed <saeedm@...dia.com>,
        Saeed Mahameed <saeed@...nel.org>,
        Lior Nahmanson <liorna@...dia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        "naveenm@...vell.com" <naveenm@...vell.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        "andrew@...n.ch" <andrew@...n.ch>
Subject: Re: [PATCH net-next V2 07/17] net/mlx5: Add MACsec offload Tx command support

On Tue, Sep 20, 2022 at 1:44 PM Antoine Tenart <atenart@...nel.org> wrote:
>
> Quoting Raed Salem (2022-09-19 15:26:26)
> > >From: sundeep subbaraya <sundeep.lkml@...il.com>
> > >As of now we will send the new driver to do all the init in the
> > >prepare phase and commit phase will return 0 always.
> > >
> > I think it is better to do all the init in commit phase and not in the
> > prepare to align with most drivers that already implemented macsec
> > offload (both aquantia and mlx5 and most of mscc implementation), this
> > will make it easier to deprecate the prepare stage in future refactor
> > of the macsec driver in stack.
>
> Yes, please do this.

Sure Raed and Antoine.

Thanks,
Sundeep

>
> Thanks,
> Antoine