netdev - [PATCH net-next 0/7] net: macsec: remove the preparation phase when offloading operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220921135118.968595-1-atenart@kernel.org>
Date:   Wed, 21 Sep 2022 15:51:11 +0200
From:   Antoine Tenart <atenart@...nel.org>
To:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com
Cc:     Antoine Tenart <atenart@...nel.org>, sundeep.lkml@...il.com,
        saeedm@...dia.com, liorna@...dia.com, dbogdanov@...vell.com,
        mstarovoitov@...vell.com, irusskikh@...vell.com,
        sd@...asysnail.net, netdev@...r.kernel.org
Subject: [PATCH net-next 0/7] net: macsec: remove the preparation phase when offloading operations

Hello,

It was reported[1] the 2-step phase offloading of MACsec operations did
not fit well and device drivers were mostly ignoring the first phase
(preparation). In addition the s/w fallback in case h/w rejected an
operation, which could have taken advantage of this design, never was
implemented and it's probably not a good idea anyway (at least
unconditionnally). So let's remove this logic which only makes the code
more complex for no advantage, before there are too many drivers
providing MACsec offloading.

This series removes the first phase (preparation) of the MACsec h/w
offloading. The modifications are split per-driver and in a way that
makes bissection working with logical steps; but I can squash some
patches if needed.

This was tested on the MSCC PHY but not on the Altantic nor mlx5e NICs.

Thanks,
Antoine

[1] https://lore.kernel.org/all/166322893264.61080.12133865599607623050@kwain/T/

Antoine Tenart (7):
  net: phy: mscc: macsec: make the prepare phase a noop
  net: atlantic: macsec: make the prepare phase a noop
  net: macsec: remove the prepare phase when offloading
  net: phy: mscc: macsec: remove checks on the prepare phase
  net: atlantic: macsec: remove checks on the prepare phase
  net/mlx5e: macsec: remove checks on the prepare phase
  net: macsec: remove the prepare flag from the MACsec offloading
    context

 .../ethernet/aquantia/atlantic/aq_macsec.c    |  57 ---------
 .../mellanox/mlx5/core/en_accel/macsec.c      |  36 ------
 drivers/net/macsec.c                          |  14 ---
 drivers/net/phy/mscc/mscc_macsec.c            | 113 ++++++------------
 include/net/macsec.h                          |   2 -
 5 files changed, 39 insertions(+), 183 deletions(-)

-- 
2.37.3