netdev - Re: [PATCH v1 1/1] ptp_ocp: use device_find_any

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7536b94-b37c-9e8a-363f-cbca652f1cbd@novek.ru>
Date:   Wed, 21 Sep 2022 21:52:15 +0100
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Vadim Fedorenko <vadfed@...com>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH v1 1/1] ptp_ocp: use device_find_any_child() instead of
 custom approach

On 21.09.2022 15:10, Andy Shevchenko wrote:
> We have already a helper to get the first child device, use it and
> drop custom approach.
> 

LGTM. This patch should go to net-next, I believe.

Acked-by: Vadim Fedorenko <vadfed@...com>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/ptp/ptp_ocp.c | 8 +-------
>   1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 83da36e69361..ebed0161879e 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -1311,12 +1311,6 @@ ptp_ocp_read_eeprom(struct ptp_ocp *bp)
>   	goto out;
>   }
>   
> -static int
> -ptp_ocp_firstchild(struct device *dev, void *data)
> -{
> -	return 1;
> -}
> -
>   static struct device *
>   ptp_ocp_find_flash(struct ptp_ocp *bp)
>   {
> @@ -1325,7 +1319,7 @@ ptp_ocp_find_flash(struct ptp_ocp *bp)
>   	last = NULL;
>   	dev = &bp->spi_flash->dev;
>   
> -	while ((dev = device_find_child(dev, NULL, ptp_ocp_firstchild))) {
> +	while ((dev = device_find_any_child(dev))) {
>   		if (!strcmp("mtd", dev_bus_name(dev)))
>   			break;
>   		put_device(last);