netdev - Re: [PATCH net-next 14/18] net: dsa: realtek: remove unnecessary set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220921215955.6ctuk4yyagog4n4o@bang-olufsen.dk>
Date:   Wed, 21 Sep 2022 21:59:56 +0000
From:   Alvin Šipraga <ALSI@...g-olufsen.dk>
To:     Yang Yingliang <yangyingliang@...wei.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "olteanv@...il.com" <olteanv@...il.com>,
        "kurt@...utronix.de" <kurt@...utronix.de>,
        "hauke@...ke-m.de" <hauke@...ke-m.de>,
        "Woojung.Huh@...rochip.com" <Woojung.Huh@...rochip.com>,
        "sean.wang@...iatek.com" <sean.wang@...iatek.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "clement.leger@...tlin.com" <clement.leger@...tlin.com>,
        "george.mccollister@...il.com" <george.mccollister@...il.com>
Subject: Re: [PATCH net-next 14/18] net: dsa: realtek: remove unnecessary
 set_drvdata()

On Wed, Sep 21, 2022 at 10:05:20PM +0800, Yang Yingliang wrote:
> Remove unnecessary set_drvdata(NULL) function in ->remove(),
> the driver_data will be set to NULL in device_unbind_cleanup()
> after calling ->remove().
> 
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/net/dsa/realtek/realtek-mdio.c | 2 --
>  drivers/net/dsa/realtek/realtek-smi.c  | 2 --
>  2 files changed, 4 deletions(-)

Acked-by: Alvin Šipraga <alsi@...g-olufsen.dk>

> 
> diff --git a/drivers/net/dsa/realtek/realtek-mdio.c b/drivers/net/dsa/realtek/realtek-mdio.c
> index c58f49d558d2..3e54fac5f902 100644
> --- a/drivers/net/dsa/realtek/realtek-mdio.c
> +++ b/drivers/net/dsa/realtek/realtek-mdio.c
> @@ -245,8 +245,6 @@ static void realtek_mdio_remove(struct mdio_device *mdiodev)
>  	/* leave the device reset asserted */
>  	if (priv->reset)
>  		gpiod_set_value(priv->reset, 1);
> -
> -	dev_set_drvdata(&mdiodev->dev, NULL);
>  }
>  
>  static void realtek_mdio_shutdown(struct mdio_device *mdiodev)
> diff --git a/drivers/net/dsa/realtek/realtek-smi.c b/drivers/net/dsa/realtek/realtek-smi.c
> index 45992f79ec8d..1b447d96b9c4 100644
> --- a/drivers/net/dsa/realtek/realtek-smi.c
> +++ b/drivers/net/dsa/realtek/realtek-smi.c
> @@ -522,8 +522,6 @@ static int realtek_smi_remove(struct platform_device *pdev)
>  	if (priv->reset)
>  		gpiod_set_value(priv->reset, 1);
>  
> -	platform_set_drvdata(pdev, NULL);
> -
>  	return 0;
>  }
>  
> -- 
> 2.25.1
>