netdev - Re: [PATCH v2 iproute2-next] ip link: add sub-command to view and change DSA master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220921154107.61399763@hermes.local>
Date:   Wed, 21 Sep 2022 15:41:07 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Ahern <dsahern@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH v2 iproute2-next] ip link: add sub-command to view and
 change DSA master

On Wed, 21 Sep 2022 18:38:28 +0000
Vladimir Oltean <vladimir.oltean@....com> wrote:

> On Wed, Sep 21, 2022 at 11:36:37AM -0700, Stephen Hemminger wrote:
> > On Wed, 21 Sep 2022 19:51:05 +0300
> > Vladimir Oltean <vladimir.oltean@....com> wrote:
> >   
> > > +.BI master " DEVICE"
> > > +- change the DSA master (host network interface) responsible for handling the
> > > +local traffic termination of the given DSA switch user port. The selected
> > > +interface must be eligible for operating as a DSA master of the switch tree
> > > +which the DSA user port is a part of. Eligible DSA masters are those interfaces
> > > +which have an "ethernet" reference towards their firmware node in the firmware
> > > +description of the platform, or LAG (bond, team) interfaces which contain only
> > > +such interfaces as their ports.  
> > 
> > We still need to find a better name for this.
> > DSA predates the LF inclusive naming but that doesn't mean it can't be
> > fixed in user visible commands.  
> 
> Need? Why need? Who needs this and since when?

Also see: https://www.kernel.org/doc/html/v6.0-rc6/process/coding-style.html#naming

For symbol names and documentation, avoid introducing new usage of ‘master / slave’ (or ‘slave’ independent of ‘master’) and ‘blacklist / whitelist’.

Recommended replacements for ‘master / slave’ are:
‘{primary,main} / {secondary,replica,subordinate}’ ‘{initiator,requester} / {target,responder}’ ‘{controller,host} / {device,worker,proxy}’ ‘leader / follower’ ‘director / performer’

Recommended replacements for ‘blacklist/whitelist’ are:
‘denylist / allowlist’ ‘blocklist / passlist’

Exceptions for introducing new usage is to maintain a userspace ABI/API, or when updating code for an existing (as of 2020) hardware or protocol specification that mandates those terms. For new specifications translate specification usage of the terminology to the kernel coding standard where possible.