netdev - Re: [PATCH -next 1/3] net: dsa: microchip: remove unnecessary spi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <facfc855-d082-cc1c-a0bc-027f562a2f45@huawei.com>
Date:   Wed, 21 Sep 2022 09:32:26 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     Vladimir Oltean <olteanv@...il.com>
CC:     <netdev@...r.kernel.org>, <davem@...emloft.net>
Subject: Re: [PATCH -next 1/3] net: dsa: microchip: remove unnecessary
 spi_set_drvdata()

Hi Vladimir,

On 2022/9/21 7:45, Vladimir Oltean wrote:
> On Tue, Sep 13, 2022 at 10:44:04PM +0800, Yang Yingliang wrote:
>> Remove unnecessary spi_set_drvdata() in ksz_spi_remove(), the
>> driver_data will be set to NULL in device_unbind_cleanup() after
>> calling ->remove().
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
>> ---
> I would like all drivers in drivers/net/dsa/ to follow the same
> convention, which they currently do. They all call .*_set_drvdata.*NULL
> from ->remove(), why just patch the spi_set_drvdata() calls?
Yes, it's right, all the set_drvdata functions in ->remove() can be 
removed. I will
send a v2 to remove all this calling.

Thanks,
Yang
> .