netdev - Re: [PATCH v2] tun: support not enabling carrier in TUNSETIFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e6d2e4b-7f08-59f0-531a-103e4bae7173@6wind.com>
Date:   Wed, 21 Sep 2022 08:35:02 +0200
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Patrick Rohr <prohr@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     Linux Network Development Mailing List <netdev@...r.kernel.org>,
        Maciej Żenczykowski <maze@...gle.com>,
        Lorenzo Colitti <lorenzo@...gle.com>,
        Jason Wang <jasowang@...hat.com>,
        Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH v2] tun: support not enabling carrier in TUNSETIFF


Le 20/09/2022 à 21:48, Patrick Rohr a écrit :
> This change adds support for not enabling carrier during TUNSETIFF
> interface creation by specifying the IFF_NO_CARRIER flag.
> 
> Our tests make heavy use of tun interfaces. In some scenarios, the test
> process creates the interface but another process brings it up after the
> interface is discovered via netlink notification. In that case, it is
> not possible to create a tun/tap interface with carrier off without it
> racing against the bring up. Immediately setting carrier off via
> TUNSETCARRIER is still too late.
> 
> Signed-off-by: Patrick Rohr <prohr@...gle.com>
> Cc: Maciej Żenczykowski <maze@...gle.com>
> Cc: Lorenzo Colitti <lorenzo@...gle.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Reviewed-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>