lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <TYBPR01MB534100D42EC0202CA8BEF04CD84E9@TYBPR01MB5341.jpnprd01.prod.outlook.com> Date: Thu, 22 Sep 2022 07:39:27 +0000 From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, "kishon@...com" <kishon@...com>, "vkoul@...nel.org" <vkoul@...nel.org>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "richardcochran@...il.com" <richardcochran@...il.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, "geert+renesas@...der.be" <geert+renesas@...der.be> CC: "andrew@...n.ch" <andrew@...n.ch>, "linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org> Subject: RE: [PATCH v2 2/8] dt-bindings: phy: renesas: Document Renesas Ethernet SERDES Hi Krzysztof, Thank you for your review! > From: Krzysztof Kozlowski, Sent: Thursday, September 22, 2022 4:29 PM > > On 21/09/2022 10:47, Yoshihiro Shimoda wrote: > > Document Renesas Etherent SERDES for R-Car S4-8 (r8a779f0). > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> > > --- > > .../bindings/phy/renesas,ether-serdes.yaml | 54 +++++++++++++++++++ > > 1 file changed, 54 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml > b/Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml > > new file mode 100644 > > index 000000000000..04d650244a6a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/renesas,ether-serdes.yaml > > Filename based on compatible, so renesas,r8a779f0-ether-serdes.yaml I got it. I'll rename the file. > > @@ -0,0 +1,54 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: <snip> > > + > > +title: Renesas Ethernet SERDES > > + > > +maintainers: > > + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com> > > + > > +properties: > > + compatible: > > + const: renesas,r8a779f0-ether-serdes > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + resets: > > + maxItems: 1 > > + > > + power-domains: > > + maxItems: 1 > > + > > + '#phy-cells': > > + description: Port number of SERDES. > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - resets > > + - power-domains > > + - '#phy-cells' > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h> > > + #include <dt-bindings/power/r8a779f0-sysc.h> > > + > > + ethernet@...80000 { > > Hm, isn't this a phy? Oops. I copied and pasted this from other patch... I'll fix this as "serdes@...44000". Best regards, Yoshihiro Shimoda > > + compatible = "renesas,r8a779f0-ether-serdes"; > > + reg = <0xe6444000 0xc00>; > > + clocks = <&cpg CPG_MOD 1506>; > > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; > > + resets = <&cpg 1506>; > > + #phy-cells = <1>; > > + }; > > Best regards, > Krzysztof
Powered by blists - more mailing lists