lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <YyxOTKJ8OTxXgWcA@lunn.ch> Date: Thu, 22 Sep 2022 14:00:12 +0200 From: Andrew Lunn <andrew@...n.ch> To: Michael Walle <michael@...le.cc> Cc: marcus.carlberg@...s.com, davem@...emloft.net, devicetree@...r.kernel.org, edumazet@...gle.com, hkallweit1@...il.com, kernel@...s.com, kuba@...nel.org, linux-kernel@...r.kernel.org, linux@...linux.org.uk, lxu@...linear.com, netdev@...r.kernel.org, pabeni@...hat.com Subject: Re: [PATCH net-next 0/2] net: phy: mxl-gpy: Add mode for 2 leds On Thu, Sep 22, 2022 at 10:05:29AM +0200, Michael Walle wrote: > Hi, > > > GPY211 phy default to using all four led pins. > > Hardwares using only two leds where led0 is used as the high > > network speed led and led1 the low network speed led will not > > get the correct behaviour since 1Gbit and 2.5Gbit will not be > > represented at all in the existing leds. > > I might be wrong, but PHY LED bindings should be integrated with/using > the LED subsystem. Although I didn't see any development regarding this > for a long time. > > That being said, it seems you are adding a new (DT) property which > just matches your particular hardware design, no? Thanks Michael Replying to this was on my TODO list. We have NACKed patches like this for a few years now, wanting the Linux LED subsystem be used to configure PHY LEDs. The patches to implement the core of that sometimes makes some progress, then goes dormant for a while. The last effort was getting close to being ready. Maybe the needs for this driver can help get them finished? Andrew
Powered by blists - more mailing lists