netdev - Re: [PATCH net v2] bnxt_en: replace reset with config timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6772ad1d-9d40-4e1e-9e61-acd5b1d9eda5@novek.ru>
Date:   Thu, 22 Sep 2022 20:09:35 +0100
From:   Vadim Fedorenko <vfedorenko@...ek.ru>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Michael Chan <michael.chan@...adcom.com>,
        Pavan Chebbi <pavan.chebbi@...adcom.com>,
        netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net v2] bnxt_en: replace reset with config timestamps

On 22.09.2022 01:38, Jakub Kicinski wrote:
> On Thu, 22 Sep 2022 01:44:30 +0300 Vadim Fedorenko wrote:
>> +		if (ptp->rx_filter == PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE) {
> 
> Doesn't ptp->rx_filter hold the uAPI values, i.e. HWTSTAMP_FILTER_* ?
> 

Thanks for catching this, Jakub.
>> +			rc = bnxt_close_nic(bp, false, false);
>> +			if (!rc)
>> +				rc = bnxt_open_nic(bp, false, false);
>> +		} else
>> +			bnxt_ptp_cfg_tstamp_filters(bp);
> 
> nit: missing brackets around the else branch

v3 is on the way, also moving to net-next and without Fixes tag