netdev - Re: [PATCH net-next v3] bnxt_en: replace reset with config timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLinAd3d6O1PKrNc4_B_MWF9kXhFrsQXpzmH3rpGYq1o3Vg@mail.gmail.com>
Date:   Thu, 22 Sep 2022 13:04:08 -0700
From:   Michael Chan <michael.chan@...adcom.com>
To:     Vadim Fedorenko <vfedorenko@...ek.ru>
Cc:     Pavan Chebbi <pavan.chebbi@...adcom.com>,
        Netdev <netdev@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Richard Cochran <richardcochran@...il.com>
Subject: Re: [PATCH net-next v3] bnxt_en: replace reset with config timestamps

On Thu, Sep 22, 2022 at 12:11 PM Vadim Fedorenko <vfedorenko@...ek.ru> wrote:
>
> Any change to the hardware timestamps configuration triggers nic restart,
> which breaks transmition and reception of network packets for a while.
> But there is no need to fully restart the device because while configuring
> hardware timestamps. The code for changing configuration runs after all
> of the initialisation, when the NIC is actually up and running. This patch
> changes the code that ioctl will only update configuration registers and
> will not trigger carrier status change, but in case of timestamps for
> all rx packetes it fallbacks to close()/open() sequnce because of
> synchronization issues in the hardware. Tested on BCM57504.
>
> Cc: Richard Cochran <richardcochran@...il.com>
> Signed-off-by: Vadim Fedorenko <vfedorenko@...ek.ru>

Thanks.
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)